rustdoc: Fix issues with cross-crate inlined associated items #46384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Visibility was missing from impl items. * Attributes and docs were missing from consts and types in impls. * Const default values were missing from traits. This unifies the code that handles associated items from impls and traits.
|
r? @frewsxcv (rust_highfive has picked a reviewer for you, use r? to override) |
| // @has - '//*[@id="associatedconstant.PublicConst"]' 'pub const PublicConst: u8' | ||
| // @has - '//*[@class="docblock"]' 'PublicConst: u8 = 123' | ||
| // @has - '//*[@class="docblock"]' 'docs for PublicConst' | ||
| // @!has - 'private_method' |
There was a problem hiding this comment.
Does this form of @!has test work? I would assume that this form was looking for an XPath, not a text string.
There was a problem hiding this comment.
This form isn't looking for an XPath
Line 51 in 0a2e9ad
There was a problem hiding this comment.
Huh, nice. I guess i'm not used to seeing that form.
|
@bors r+ Thanks! |
|
📌 Commit b444843 has been approved by |
kennytm
added
the
S-waiting-on-bors
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Nov 30, 2017
…etMisdreavus rustdoc: Fix issues with cross-crate inlined associated items * Visibility was missing from impl items. * Attributes and docs were missing from consts and types in impls. * Const default values were missing from traits. This unifies the code that handles associated items from impls and traits.
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Nov 30, 2017
…etMisdreavus rustdoc: Fix issues with cross-crate inlined associated items * Visibility was missing from impl items. * Attributes and docs were missing from consts and types in impls. * Const default values were missing from traits. This unifies the code that handles associated items from impls and traits.
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Nov 30, 2017
…etMisdreavus rustdoc: Fix issues with cross-crate inlined associated items * Visibility was missing from impl items. * Attributes and docs were missing from consts and types in impls. * Const default values were missing from traits. This unifies the code that handles associated items from impls and traits.
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Nov 30, 2017
…etMisdreavus rustdoc: Fix issues with cross-crate inlined associated items * Visibility was missing from impl items. * Attributes and docs were missing from consts and types in impls. * Const default values were missing from traits. This unifies the code that handles associated items from impls and traits.
bors
added a commit
that referenced
this pull request
Dec 3, 2017
rustdoc: Fix issues with cross-crate inlined associated items * Visibility was missing from impl items. * Attributes and docs were missing from consts and types in impls. * Const default values were missing from traits. This unifies the code that handles associated items from impls and traits.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unifies the code that handles associated items from impls and traits.